On Mon, Feb 20, 2012 at 4:22 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > Defining them makes code more readable, but without X_OK being 0 on Windows > openvpn crashes. See my commit message again and read the MSDN page about > _access at http://msdn.microsoft.com/en-us/library/1w06ktdy%28v=vs.100%29.aspx > Hence the change for the MSVC buildsystem only. Mingw handles the situation > internally already. > > Hope that made it clear.
Yes, it is clear. Still, it is not correct to override well defined constants. Windows is windows, it is inappropriate to have one constant value for mingw and another for msvc. I will submit a different patch. Alon.
