Hi, On Tue, Feb 21, 2012 at 05:44:13PM +0000, Heiko Hund wrote: > This reverts commit 4ebc587e. Instead of defining X_OK 0 for MSVC, > this undefined mode value is now simply masked out close to where > it causes the trouble; in the call to _waccess() as suggested > during the discussion on the development mailing list: > http://thread.gmane.org/gmane.network.openvpn.devel/5452 > > Signed-off-by: Heiko Hund <heiko.h...@sophos.com>
I suggested this approach, so I should ACK it - but I'm not happy yet: there really should be a comment in the code explaining why this is done - without that, this looks like "just random modification of flag bits", and you need to go to the *git log* to see why this was done. A comment like: /* Passing X_OK to _(w)access() on windows will cause a crash on * Vista and up. To avoid more complicated code in the calling * functions, we just mask out X_OK on windows. See also * http://msdn.microsoft.com/en-us/library/1w06ktdy%28v=vs.100%29.aspx */ should be fine. But maybe I'm just old enough to revisit code 10 years later and ask myself "why did I do that?"... gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpNw2hYpwnok.pgp
Description: PGP signature
