Hi, Shouldn't the return type be size_t or at least unsigned int, as mbuf->len is also of type unsigned int?
-Steffan -----Original Message----- From: Arne Schwabe [mailto:a...@rfc2549.org] Sent: maandag 11 maart 2013 22:35 To: g...@greenie.muc.de; openvpn-devel@lists.sourceforge.net Subject: Re: [Openvpn-devel] [PATCH] Repair "tcp server queue overflow" brokenness, more <stdbool.h> fallout. On 11.03.2013 21:10, g...@greenie.muc.de wrote: > From: Gert Doering <g...@greenie.muc.de> > > Return value of mbuf_len() wrong - it's returning a length value, not > a yes/no value - so when the queue length approached 65 (full!), it > still only returned "1", leading to MBUF overflow later on. Change > from "bool" to "int", misbehaviour gone... > > ACK. I did not check if that fixes the issue but the change is correct. Arne ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
