I'll ACK the bool -> int patch, it resolves the issue in ticket 263.
________________________________________
Från: Gert Doering [g...@greenie.muc.de]
Skickat: den 12 mars 2013 11:07
Till: Steffan Karger
Cc: openvpn-devel@lists.sourceforge.net
Ämne: Re: [Openvpn-devel] [PATCH v2] Repair "tcp server queue overflow"
brokenness, more <stdbool.h> fallout.
Hi,
On Tue, Mar 12, 2013 at 09:32:36AM +0100, Steffan Karger wrote:
> Shouldn't the return type be size_t or at least unsigned int, as mbuf->len is
> also of type unsigned int?
Well, unsigned int, as ->len is not a size_t.
Not that it makes any real difference as we're talking about a range
between "0" and "65" here. But anyway. Patch v2 is below.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
