Hi, On Fri, May 02, 2014 at 05:20:02PM +0200, David Sommerseth wrote: > - Why not re-use facilitynames[] from sys/syslog.h, instead of adding > something which is basically a duplicate of exactly that lookup table?
Oh, wow. I didn't know that this exists - learned something new today.
We might have to figure out how this is portably used - I see it exists
on Linux and FreeBSD, at least, and both have it inside #ifdef SYSLOG_NAMES,
so our code might have to do
#define SYSLOG_NAMES
#include <sys/syslog.h>
or such. Plus possibly an autoconf test to see whether it's there, and
if not, fall back to something in compat/ - that would make the change
to options.c much smaller.
> - Further, why the #ifdef's on LOG_FTP, LOG_SYSLOG, LOG_UUCP?
"Because not all systems have them", I'd say :-) - syslog facilities are
far from universal, alas.
[..]
> Using --syslog-facility is a bare minimum acceptable but not preferred.
> Rather consider --daemon [progname] [facility] and --syslog [progname]
> [facility]. If facility is not set, default to whatever is the default now
> (IIRC, it is syslog).
I think it would be good to loosen the restrictions that --syslog has
to be called before --daemon, and move that to "latest option wins"
(as usual). Haven't checked the code to see how complicated that is.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpPk68MvBMgg.pgp
Description: PGP signature
