Hi,

On Sun, Aug 30, 2015 at 04:25:34PM +0200, Lukasz K. wrote:
> -  if (c->first_time && c0 && !c0->uid_gid_set)
> +  if (c0 && !c0->uid_gid_set)
>      {
>        /* chroot if requested */
>        if (c->options.chroot_dir)
>       {
>         if (no_delay)
>           platform_chroot (c->options.chroot_dir);
> -       else
> +       else if (c->first_time)
>           msg (M_INFO, "NOTE: chroot %s", why_not);
>       }

Looking a bit more closely at this one.  What happens if you do not
set uid/gid, but *do* set --chroot?  Will it then execute the chroot
call every single time (since effectively the first_time check is
removed, and c0->uid_git_set will never be set)?

Or am I misreading this?

gert

-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: pgpT_1WaDHsCU.pgp
Description: PGP signature

Reply via email to