Hi, On Tue, Nov 24, 2015 at 08:49:08PM +0300, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. > Please use the attached version. > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version.
Thanks for the attachments, this should work out nicely. There is something I'd ask you to change, though - all these new additions to win32.h are really only needed for the benefit of win32.c (the DEFINE_GUID stuff), but win32.h is included from a LOT of places - so it would be much cleaner to have this inside win32.c, and only export the function prototypes > +bool win_wfp_block_dns(const NET_IFINDEX index); > +bool win_wfp_uninit(); > +bool win_wfp_init(); towards users. Another thing I wonder - why have two functions for _init() and _block_dns(), which in the end is either called both, or not at all. Couldn't this be just folded into one function (_block_dns()) which calls _init() internally? This would reduce the impact on other code paths even further... Lastly, not all of the new #include files are #ifdef'ed for _WIN32_WINNT - are these all available on XP already, even if the libraries are not? thanks, gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature