Hi,

I did some tests on the patch for 2.3 [*]. Build for vista+ needed some
hacking of configure.ac (but that's not relevant for this patch).

For XP+, it builds out of the box. When the resulting exe is run on windows
7 with --block-outside-dns, it prints the following warning

"NOTE: block-outside-dns option works only on Windows"

Apart from the confusing warning, I had expected the process to exit with
unknown option error.

+#if _WIN32_WINNT >= 0x0600
> +      options->block_outside_dns = true;
> +#else
> +      msg (M_WARN, "NOTE: block-outside-dns option works only on
> Windows");


This has to be something like  "... not supported in this version or build"
or some such..

In fact, that #else clause short-circuits the default error handling of
unknown/unsupported options. It may be best to omit it altogether and let
the final if-block handle the unknown option. Or at least use msglevel_fc
in place of M_WARN so that it will exit if appropriate to do so.

+#endif


Selva

[*] v5 2.3 patch with the missing include <initguid.h> manually added.

Reply via email to