ACK. https://msdn.microsoft.com/en-us/library/windows/desktop/dd374130(v=vs.85).aspx explains about WideCharToMultiByte() usage with cbMultiByte==0.
I'm not sure if I understand in which scenarios data is fed to the nascent openvpn.exe on stdin - buf if done at all, we should better do it right :-) - I do wonder, though, if WriteFile() could block here, leading to a dead worker thread... all other pipe operations seem to go through AsyncPipeOp() - but that is orthogonal to this fix) Your patch has been applied to the master branch. commit 3654d953eb0bf40fb8c9e1fbaa3de1dd898dcbab Author: Selva Nair List-Post: [email protected] Date: Sun Mar 6 00:22:02 2016 -0500 Use appropriate buffer size for WideCharToMultiByte output in interactive.c Signed-off-by: Selva Nair <[email protected]> Acked-by: Gert Doering <[email protected]> Message-Id: <[email protected]> URL: http://article.gmane.org/gmane.network.openvpn.devel/11318 Signed-off-by: Gert Doering <[email protected]> -- kind regards, Gert Doering
