Hi, On Sun, Mar 6, 2016 at 4:31 AM, Gert Doering <g...@greenie.muc.de> wrote:
> > I'm not sure if I understand in which scenarios data is fed to the > nascent openvpn.exe on stdin - buf if done at all, we should better do > it right :-) - I do wonder, though, if WriteFile() could block here, > leading to a dead worker thread... all other pipe operations seem to > go through AsyncPipeOp() - but that is orthogonal to this fix) This is used for writing the management password to stdin. The GUI sends an "ascii" password, but a client could potentially use some char set that needs 3 or 4 bytes per char. And you are right, the write should not block. We don't see any deadlock even when openvpn errros out early, because of buffering, I suppose.. But bettter to make this non-blocking. Selva
