Hi Ilya,
>
>
> Hello,
>
> it is not very ethical to allow people to open PR in order to say later "hey,
> you know, we do not accept PR”
Thanks for bringing that up!
>
> I suggest to enable https://nopullrequests.appspot.com/
> <https://nopullrequests.appspot.com/> on https://github.com/openvpn/openvpn
> <https://github.com/openvpn/openvpn> repo, it looks like a polite way of
> saying things.
I kind of understand why openvpn does not use github pull requests to merge
(although I might debate that).
Personally I like the github PR workflow, because it makes it much easier to
view larger changes in context. Especially more complex patches typically need
a few roundtrips.
What I would like to know is: Wether “please give feedback to this PR, before I
send it to the list” is considered a viable (maybe even polite) way to only
send (large) patches that have already been peer reviewed on the list.
>
> ideas?
IMHO: If there is consent that we do not want to allow GitHub PRs for any use
case - disable it.
I have a strong preference for using GitHub at least for vetting out most bugs.
Jens
>
> Ilya Shipitsin
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications Manager
> Applications Manager provides deep performance insights into multiple tiers of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z_______________________________________________
> Openvpn-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
