Hi, On Mon, May 02, 2016 at 09:14:02AM +0200, Jens Neuhalfen wrote: > I kind of understand why openvpn does not use github pull requests to merge > (although I might debate that). > > Personally I like the github PR workflow, because it makes it > much easier to view larger changes in context. Especially more > complex patches typically need a few roundtrips.
This is true (though we usually succeeded quite well with "discuss the
idea by mail or IRC, and then base the first round of patch on that,
and the second round gets in" :-) )
> What I would like to know is: Wether ???please give feedback to this PR,
> before I send it to the list??? is considered a viable (maybe even polite)
> way to only send (large) patches that have already been peer reviewed on the
> list.
I've seen you do it, but as we're notoriously short of reviewer brain
cycles, nothing has happened yet - but that does not mean it's a bad
idea (or a good idea)...
> IMHO: If there is consent that we do not want to allow GitHub PRs for any use
> case - disable it.
>
> I have a strong preference for using GitHub at least for vetting out most
> bugs.
We're not going to use GitHub for the actual patch merging process - that
is "mailing list, public ACK, merge, push to github + sourceforge", at
least today.
For review, PRs should be doable.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
