HI, On Mon, May 2, 2016 at 11:38 AM, Илья Шипицин <chipits...@gmail.com> wrote: > it is already running at "coverity_scan" branch: > https://travis-ci.org/OpenVPN/openvpn/builds/120718429 > > so, it definitely good
Well, "it seems to work" is one thing, but a review should also cover whether some change or addition is doing the right thing and doing it the right way. Given your remark below, it seems that you just did that. So thanks for that. > however, I would add (to make build running on ubuntu trusty) > > sudo: required > dist: trusty Running on Trusty would be nicer indeed (more recent compilers and tools), but the Trusty environment is still in Beta. I'd suggest to switch once travis-ci removes the 'beta' label. (As a side note, please don't top-post in mailinglist conversations.) -Steffan
