Hi, Sorry for not noticing before, but one last nit:
On Wed, May 25, 2016 at 7:57 PM, <openvpn-de...@neuhalfen.name> wrote: > +/* Read 'tosearch', replace all occurences of 'searchfor' with > 'replacewith' and return > + * a pointer to the NEW string. Does not modify the input strings. Will > not enter an > + * infinite loop with clever 'searchfor' and 'replacewith' strings. > + * Daniel Johnson - progman2...@usa.net / djohn...@progman.us > + * > + * Retuns NULL when > + * - any parameter is NULL > + * - the worst-case result is to large ( >= SIZE_MAX) > + */ Now that you're touching these anyway, let's turn these into doxygen-style comments (/** */). But maybe Gert/David can do that when applying the patch, a v2 just for this seems a bit too much. Also goes for: > +/* > + * Given an environmental variable name, search > + * the envp array for its value, returning it > + * if found or NULL otherwise. > + */ and > +/* > + * Return the length of a string array > + */ But for everything else: ACK. Cool to have the infrastructure for unit testing in place. Let's hope others will now thankfully make use of this. -Steffan
