Hi, On Wed, May 25, 2016 at 07:57:55PM +0200, openvpn-de...@neuhalfen.name wrote: > From: Jens Neuhalfen <j...@neuhalfen.name> > > cmocka [1,2] is a testing framework for C. Adding unit test capabilities to > the > openvpn repository will greatly ease the task of writing correct code. > > cmocka source code is added as git submodule in ./vendor. A submodule approach > has been chosen over a classical library dependency because libcmocka is not > available, or only available in very old versions (e.g. on Ubuntu). > > cmocka is build during 'make check' and installed in vendor/dist/. > > [1] https://cmocka.org/ > [2] https://lwn.net/Articles/558106/
This patch needs more work - David merged it tonight, and it blew up half
our buildslaves.
Two main issues I could identify:
- if cmake is not installed, it should result in "SKIPPED" tests, not in
build/make failures - since we do not list it in our build requirements
(and we shouldn't, for normal builds), building and testing needs to be
possible if cmake is not existing - of course, without the cmocka tests
- if the build is done in a directory with blanks in, which our buildbots
like to do, things blow up due to lack of quoting
rm -rf
/var/lib/buildbot/slaves/openvpn/build-ubuntu-1204-i386-stable-master--disable-server
--enable-small /build/vendor/.build/cmocka
rm: unrecognized option '--enable-small'
the "--enable-small" bit is part of the current directory name, and
has a blank before it... (which might not be considered good practice,
but better it blows up for us than for users)
It also blows up in configure already when building for windows, but I'm
not sure I understand why - Samuli is looking into that.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
