Hi, On Wed, Oct 05, 2016 at 05:29:46PM +0200, Lev Stipakov wrote: > I noticed that in few places indentation is a bit off - like 8 whitespaces > instead of tab so I decided to "fix" it. > > Should I just ignore those things or do it in separate PR?
Please do not intermix whitespace changes with "other changes" - this
makes it harder to track what really changed in a patch.
We are planning to do a massive re-indentation before 2.4 release
(right when we branch off the release/2.4 branch, or so) - so I'd not
bother right now.
If you do actual code changes to a line that has funny whitespace, of
course feel free to fix that as well ;-)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
