-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/10/16 17:29, Lev Stipakov wrote: > Hi, > > > I am, and the first version is what we do in (most?) other places, > so I'll change that on the fly. > > > Got it. > > > Also, the patch introduces spurious tab<->whitespace changes "close > to comments" in a few places - will undo those, too. > > > I noticed that in few places indentation is a bit off - like 8 > whitespaces instead of tab so I decided to "fix" it. > > Should I just ignore those things or do it in separate PR?
Currently I think we can leave them. Before the release of 2.4-RC we will do a lot of coding style fixes to the whole source tree, so that we have one unified coding style over the whole code base in both the new releases/2.4 and master branch. The Hackathon in Munich 2014 [1] decided on the the Allmann style [2]. The only thing I'm not sure we agreed upon is the indent size (4 or 8 spaces), in addition to the line length which is not that explicitly agreed upon. [1] <https://community.openvpn.net/openvpn/wiki/MunichHackathon2014> [2] <https://en.wikipedia.org/wiki/Indent_style#Allman_style> - -- kind regards, David Sommerseth OpenVPN Technologies, Inc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJX9UWvAAoJEIbPlEyWcf3ytj4P/iuXf+htHtFjQfE9/QSWY/Ui +jpF1kqlAKac6eS1t0cN1OYVUmXZwNkZjGNKYl8vi9zVSciZf2rFslTAhaaRLuWW LMtL1MxGJbADvLpKkHPfvSNk3ITXxhnMKjgXqzxnPY2WeyV7f48jKOUeBma3RY1R m4hT8Hg0Im2cqVmU9XRDvEc3u0EqTKzA/NP6sKO1dWut05ZwKlIyUknsJfLoZyEx OPghZaTgFmz0YZKQqam0cenkL2g3cYuz60GQw8Lpio6GFLQMMbjV9fRpdIJ4d36W qIdulNh+idXDvuSe3bFFQqYItdUIIgaBvz8dUDCubz47OR6vkTD+/+KR0f4F5C/9 HHt1CW4GAs5AEvFpF9BhPoxajQHNjoZsrWOL+YgumVKcTUclgd/iUoRTBusSF87H fYp/b7XjLO1cr1QPprK0szzNQB4HMFx3aVxZlvhC8WePN+uO8a6X55g08pnuy7kS PQ5nrfOywwQsqhl9p9E5lFV2HoeIfxGkwjoq4xztGI9xyV3jFroaqn4cN9314+aF RREgmCYInDEZzVXjqFCC/0isgEXOYdC/p6Hpy6EWzCecFf8fm1Gs4CQnhodR7Min QyKZhhC/yAXgOKuEKCPw+NY+eulE1VwRmIBEJujKgeVBNVIoaQc43wEARIYhTdcO SrffianKpvhWJiPjLRUd =TF/Z -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
