Hi, I didn't look at the code itself (David already did), but two very minor nitpicks I ran into while rebasing my src/openvpn/* unit tests on this patch:
On 28-10-16 18:42, Heiko Hund wrote: > --- a/configure.ac > +++ b/configure.ac > @@ -1273,6 +1273,7 @@ AC_CONFIG_FILES([ > tests/unit_tests/plugins/Makefile > tests/unit_tests/plugins/auth-pam/Makefile > tests/unit_tests/example_test/Makefile > + tests/unit_tests/openvpn/Makefile > vendor/Makefile Could we keep this ordering alphabetical? (And fix the example_test occurrence as we go?) > diff --git a/tests/unit_tests/Makefile.am b/tests/unit_tests/Makefile.am > index 8868c1c..44ab26b 100644 > --- a/tests/unit_tests/Makefile.am > +++ b/tests/unit_tests/Makefile.am > @@ -1,5 +1,5 @@ > AUTOMAKE_OPTIONS = foreign > > if CMOCKA_INITIALIZED > -SUBDIRS = example_test plugins > +SUBDIRS = example_test plugins openvpn > endif Here too alphabetical ordering would be a little nicer. Maybe David can tackle this when applying? -Steffan
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
