ACK, thanks.
The patch does what we agreed on in the trac ticket ("no user changes"
for the normal case, and "in the service pipe change, imply def1 if
no flags set"). This is very little extra code and easily checked,
while fixing this in other ways would need much more code - for a sort-of
historic approach to routing table handling (we really shouldn't be
*removing* other people's routes, and we don't do that for IPv6 either).
Semi-ACK on the approach from Arne ("that's what we do on Android") :-)
I've added a note to Changes.rst.
Your patch has been applied to the master branch.
commit 788e5e4a08e0df7206d17e9cbc135764d6fc385f
Author: Selva Nair
Date: Tue Nov 29 19:39:32 2016 -0500
Force 'def1' method when --redirect-gateway is done through service
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <1480466372-2396-1-git-send-email-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13307.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
