David Sommerseth <open...@sf.lists.topphemmelig.net> on Fri, 2016/12/09 22:37: > On 29/11/16 12:07, Christian Hesse wrote: > > From: Christian Hesse <m...@eworm.de> > > > > Drop --with-plugindir, instead use an environment variable PLUGINDIR > > to specify the plugin directory. > > > > This always defines PLUGIN_LIBDIR and enables plugin search path. > > > > Signed-off-by: Christian Hesse <m...@eworm.de> > > --- > > configure.ac | 14 ++++++-------- > > src/openvpn/Makefile.am | 3 ++- > > 2 files changed, 8 insertions(+), 9 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index f4073d0..5fe652e 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -301,13 +301,12 @@ AC_ARG_WITH( > > [with_crypto_library="openssl"] > > ) > > > > -AC_ARG_WITH( > > - [plugindir], > > - [AS_HELP_STRING([--with-plugindir], [plugin directory > > @<:@default=LIBDIR/openvpn@:>@])], > > - , > > - [with_plugindir="\$(libdir)/openvpn/plugins"] > > -) > > - > > +AC_ARG_VAR([PLUGINDIR], [Path of plug-in directory > > @<:@default=LIBDIR/openvpn/plugins@:>@]) +if test -n "${PLUGINDIR}"; then > > + plugindir="${PLUGINDIR}" > > +else > > + plugindir="\${libdir}/openvpn/plugins" > > +fi > > Finally had some time to dig into this one. I like the idea here, I > think it makes sense. But I'm not sure ${libdir} is correct by default. > I think that should be /usr/local/lib64 by default on a 64bit system. > > My google-foo isn't helpful for me today ... This is somewhat related, > especially towards the end of this doc page: > <https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Site-Defaults.html> > > But I believe there are better ways to do this. > > I haven't checked this in detail what happens with 'make install'. We > should ensure that the plug-ins we ship (./src/plugins) which are built > are installed as well into this directory.
${libdir} is where plugins are installed to... That's why I choose it. ;) Installing anything to $prefix/lib64/ does not make sense imho. Never. 32bit systems install to $prefix/lib/, 64bit system install to $prefix/lib/. The only valid extra is $prefix/lib32/ for multilib on 64bit systemd. -- main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];) putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
pgpYJbsIcTxRu.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel