On 25/01/17 17:04, Christian Hesse wrote: > From: Christian Hesse <m...@eworm.de> > > Drop --with-plugindir, instead use an environment variable PLUGINDIR > to specify the plugin directory. > > This generates a header file src/openvpn/plugindir.h which contains a > define file the plugindir. > > v2: The configure script can not evaluate the final $libdir path. So > use make to create a header file on the containing the final path. > > v3: Fix whitespace errors and gitignore location. > > Signed-off-by: Christian Hesse <m...@eworm.de> > --- > .gitignore | 1 + > configure.ac | 14 ++++++-------- > src/openvpn/Makefile.am | 11 +++++++++-- > src/openvpn/plugin.c | 1 + > src/openvpn/plugindir.h.in | 34 ++++++++++++++++++++++++++++++++++ > 5 files changed, 51 insertions(+), 10 deletions(-) > create mode 100644 src/openvpn/plugindir.h.in
Okay, some more feedback to this thread :) As I've said, I think this makes sense. It provides a predictable plug-in directory which is easily accessible within the C code ... and it will always be set. So, Feature-ACK. But I am wondering about the rationale of adding another header file (plugindir.h). Why not just add this information to openvpn-plugin.h.in, which results into openvpn-plugin.h ... and which plugin.c already includes via plugin.h ... I actually think this path can be quite useful for third-party plug-ins, being built outside of the openvpn source tree. Further, we should then also kick out the #ifdef PLUGIN_LIBDIR in plugin_init_item() [plugin.c:237]. And we need to check what the #if defined(ENABLE_PLUGIN_SEARCH) is all about ... I do not see any possibilities to define the ENABLE_PLUGIN_SEARCH macro without changing a .c/.h file. Does this block even make sense to enable at all? So, as this patch got "clean-up" and "plugin path handling" in the subject, lets cover a few more aspects of this clean-up :) -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
