Il 19/12/2016 10:22, Илья Шипицин ha scritto: > > > 2016-11-27 4:29 GMT+05:00 David Sommerseth > <open...@sf.lists.topphemmelig.net > <mailto:open...@sf.lists.topphemmelig.net>>: > > On 26/11/16 12:32, Илья Шипицин wrote: > > > > > > 2016-11-21 22:49 GMT+05:00 Gert Doering <g...@greenie.muc.de > <mailto:g...@greenie.muc.de> > > <mailto:g...@greenie.muc.de <mailto:g...@greenie.muc.de>>>: > > > > Hi, > > > > On Mon, Nov 21, 2016 at 10:31:45PM +0500, ???????? ?????????????? > wrote: > > > this line > > > > > > > https://github.com/OpenVPN/openvpn/blob/master/tests/unit_tests/openvpn/Makefile.am#L17 > > <https://github.com/OpenVPN/openvpn/blob/master/tests/unit_tests/openvpn/Makefile.am#L17> > > > <https://github.com/OpenVPN/openvpn/blob/master/tests/unit_tests/openvpn/Makefile.am#L17 > > <https://github.com/OpenVPN/openvpn/blob/master/tests/unit_tests/openvpn/Makefile.am#L17>> > > > > > > causes an error > > > > GNU LD manpage says this is a trick to make it link "another > function" > > "--wrap parse_line" would make it link __wrap_parse_line() instead - > > most likely because @d12fk provided a stub function that mocks the > > result (or whatever). > > > > Have not looked into this in more detail. > > > > > > http://www.mockator.com/projects/mockator/wiki/Wrap_Functions > <http://www.mockator.com/projects/mockator/wiki/Wrap_Functions> > > > > "Alas, this feature is *only available with the GNU tool chain on > > Linux*. GCC for Mac OS X does not offer the linker flag |-wrap|. " > > > > should we skip those tests on osx ? or someone will rewrite them ? > > I'd hold back a little bit. I know Arne, Heiko and some people from > #cmocka on FreeNode had a discussion about this issue earlier this week. > I don't know what they agreed on, but there was a discussion where they > looked at a few alternatives at least. > > > > any news on that ? >
We discussed this in previous IRC meeting, and there is still no real fix: <https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13558.html> The easiest "fix" would be to just disable cmocka unit tests for MacOS X in .travis.yml. I believe the unit tests behave exactly the same on every platform(?), so removing MacOS X would not have any negative impact on code quality. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
