Hi, On Mon, Jan 02, 2017 at 03:28:58PM +0100, Gisle Vanem wrote: > Just as an experiment, I compiled openvpn.exe using MinGW w/o > 'ENABLE_CRYPTO' defined. Duh, you think. What would be the benefit of > that? I ask myself the same. This code (at line 4079): > > #else /* ifdef ENABLE_CRYPTO */ > fprintf(fp, usage_message, > title_string, > o.ce.connect_retry_seconds, > o.ce.local_port, o.ce.remote_port, > TUN_MTU_DEFAULT, TAP_MTU_EXTRA_DEFAULT, > o.verbosity); > #endif > > uses a 'title_string[]' as format with no parameters specified and > thus crashes as expected. So is all code outside '!defined(ENABLE_CRYPTO)' > really dead code or what?
Actually, "usage_message" is the format string here...
There might still be bugs here, though - as in: someone adapted the
"#ifdef ENABLE_CRYPTO" part of the usage_message and forgot to change
arguments in the the #else case. While we do test builds with
--disable-crypto, I'm not sure anyone has run "openvpn --help" with
such a build in the last 5 years...
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
