Gert Doering wrote:
>> uses a 'title_string[]' as format with no parameters specified and
>> thus crashes as expected. So is all code outside '!defined(ENABLE_CRYPTO)'
>> really dead code or what?
>
> Actually, "usage_message" is the format string here...
Ah, my bad. Then it's a simple fix:
--- a/options.c 2017-01-02 09:58:38
+++ b/options.c 2017-01-02 17:15:10
@@ -4080,6 +4080,7 @@
fprintf(fp, usage_message,
title_string,
o.ce.connect_retry_seconds,
+ o.ce.connect_retry_seconds_max,
o.ce.local_port, o.ce.remote_port,
TUN_MTU_DEFAULT, TAP_MTU_EXTRA_DEFAULT,
o.verbosity);
> There might still be bugs here, though - as in: someone adapted the
> "#ifdef ENABLE_CRYPTO" part of the usage_message and forgot to change
> arguments in the the #else case. While we do test builds with
> --disable-crypto, I'm not sure anyone has run "openvpn --help" with
> such a build in the last 5 years...
--
--gv
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
