2017-01-31 18:49 GMT+05:00 David Sommerseth <
open...@sf.lists.topphemmelig.net>:
> On 30/01/17 13:34, Samuli Seppänen wrote:
> > I agree with you on keeping the pull request template minimal and having
> > the more fine-grained information in Trac.
> >
> > ACK.
>
> Don't get me wrong! I agree we should keep the template minimal. But I
> yet have to see a developer full of enthusiasm with a fix ready, who
> just clicked "Send pull request!" who will actually instantly go reading
> further. And especially when the information need is fairly
> comprehensive and not even directly in the first URL being listed.
>
> In fact the first place where the patch process is described is here:
> <https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation#
> Communitypatchesandtheacceptanceprocessofthesepatches>.
> That is "hidden" in the middle of the wiki on the second URL. And the
> first URL provides just a link to the same DeveloperDocumentation wiki
> page.
>
> So I kindly ask you to reconsider the text more carefully once more.
>
well, I double checked everything, including refrigerator, unfortunately,
current text is the best I have.
@mattock, do you have a better text ?
>
> From my experience, to get the best success, provide the most critical
> and as accurate information as quickly as possible. Once things are
> behind one URL you need to visit, many ignores it. If you need to read
> through more text on that URL, even more will fall off. But provide
> links to the more verbose documentation, as some will read it if the
> first 2-3 sentences sounds intriguing and the contributor have time to
> be curious.
>
> Most developers are lazy beasts ... they just want their patches out
> ASAP, and documentation are too easily ignored.
>
>
> --
> kind regards,
>
> David Sommerseth
> OpenVPN Technologies, Inc
>
>
>
> > On 30/01/2017 08:48, Илья Шипицин wrote:
> >> can we merge it ?
> >> @mattock ?
> >>
> >> 2017-01-21 13:47 GMT+05:00 Илья Шипицин <chipits...@gmail.com
> >> <mailto:chipits...@gmail.com>>:
> >>
> >>
> >>
> >> 2017-01-21 0:24 GMT+05:00 David Sommerseth
> >> <open...@sf.lists.topphemmelig.net
> >> <mailto:open...@sf.lists.topphemmelig.net>>:
> >>
> >> On 13/01/17 10:05, Samuli Seppänen wrote:
> >> > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
> >> >> ---
> >> >> .github/PULL_REQUEST_TEMPLATE.md | 8 ++++++++
> >> >> 1 file changed, 8 insertions(+)
> >> >> create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
> >> >>
> >> >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md
> b/.github/PULL_REQUEST_TEMPLATE.md
> >> >> new file mode 100644
> >> >> index 0000000..d0cfd7f
> >> >> --- /dev/null
> >> >> +++ b/.github/PULL_REQUEST_TEMPLATE.md
> >> >> @@ -0,0 +1,8 @@
> >> >> +# Thank you for your contribution
> >> >> +
> >> >> +You are welcome to open PR, but they are used for
> discussion only. All
> >> >> +patches must eventually go to the openvpn-devel mailing
> list for review.
> >> >> +For details, see these Wiki articles:
> >> >> +
> >> >> +* https://community.openvpn.net/openvpn/wiki/Contributing
> >> <https://community.openvpn.net/openvpn/wiki/Contributing>
> >> >> +* https://community.openvpn.net/openvpn/wiki/
> DeveloperDocumentation <https://community.openvpn.net/openvpn/wiki/
> DeveloperDocumentation>
> >> >>
> >> >
> >> > Based on testing in the travis-openssl-test repository the
> template
> >> > works as intended, so ACK on that part.
> >> >
> >> > Any comments on the text itself?
> >>
> >> How does this work with branches? Do we need to say that new
> >> patches
> >> should go into the master branch primarily, unless it is fixing
> >> a bug or
> >> another issue which is only relevant for specific release
> branches?
> >>
> >>
> >>
> >> we can put such information to
> >>
> >> https://community.openvpn.net/openvpn/wiki/Contributing
> >> <https://community.openvpn.net/openvpn/wiki/Contributing>
> >> https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
> >> <https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation>
> >>
> >>
> >> I would leave PR template skinny
> >>
> >>
> >>
> >>
> >> --
> >> kind regards,
> >>
> >> David Sommerseth
> >> OpenVPN Technologies, Inc
> >>
> >>
> >>
> >>
> >
> >
>
>
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
