On Wed, Feb 22, 2017 at 02:07:06PM +0500, Илья Шипицин wrote: > 2017-02-22 13:30 GMT+05:00 Steffan Karger <steffan.kar...@fox-it.com>: > > > On 22-02-17 08:39, Gert Doering wrote: > > > On Wed, Feb 22, 2017 at 02:21:35AM +0100, David Sommerseth wrote: > > >>>> >From d97f526a2ddbf2abe60a64260601ebd742fc00cc Mon Sep 17 00:00:00 > > 2001 > > >>>> From: "Simon (simix)" <via-trac> > > >>> > > >>> Do we have a policy how to handle patches with missing author info? > > >> > > >> I see no reason at all why we should not give proper credit with full > > >> name. > > > > > > That was only half the question - of course I *want* to give full > > credits, > > > but is "not having this information available & no SoB line" a reason > > > for rejecting a patch? > > > > > > The patch in question is quite obvious, so this is not something to bring > > > in the lawyers - more a matter of general policy. > > > > Same here. > > > > For this specific patch: I asked the reporter on trac for full name and > > email last night. We can wait for a bit to see if he replies. > > > > In general: what do we do when we don't get a full name and email, but > > do want to apply the patch? Wait forever? Claim authorship (but refer > > to the trac ticket in the commit msg)? Apply anyway? ...? > > > > if there are trac templates (I'm not very familiar with trac internals), we > can turn on the requirement of > > 1) full name > 2) legacy agreements > > on the trac side
personally I think that trac is not the place to submit patches, and this problem could re-appear anywhere: i.e. a patch for openvpn submitted somewhere else reporting no name/email. -- Antonio Quartulli
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
