Hi, returning to this patchset about printing the LZ4 library version...
On Sat, Sep 23, 2017 at 10:52:16AM +0200, Simon Matter wrote:
> > On Thu, Sep 07, 2017 at 10:40:21PM +0200, Simon Matter wrote:
> >> While we are at it, I found it useful to see the used LZ4 version at
> >> runtime as it is done with LZO and other libraries.
I still like this :-)
[..]
> > Feature-ACK (I think this is a useful idea, for the same reasons we have
> > LZO and OpenSSL versions :-) ), but that will not work if we use
> > compat-lz4.h, so "code NAK".
>
> IIRC at the time of writing this, the embedded lz4 was too old and didn't
> have the LZ4_versionString() function. So the code won't work with the
> patch. If the embedded code has LZ4_versionString() now, it should be ok.
It now has... (1.7.5).
I'm not sure where LZ4_versionString() got introduced, though - their
git repo does not have tags for 1.7.1 or 1.7.2, it is in the 1.7.3 tag,
but not in the "last of the old numbering scheme" version.
Our configure.ac requires 1.7.1 - so if LZ4_versionString() is not in
there yet, we might want to bump to 1.7.3 then.
Can you revisit this?
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
