Hi, On Mon, Nov 06, 2017 at 08:15:54AM +0100, Simon Matter wrote: > > It now has... (1.7.5). > > > > I'm not sure where LZ4_versionString() got introduced, though - their > > git repo does not have tags for 1.7.1 or 1.7.2, it is in the 1.7.3 tag, > > but not in the "last of the old numbering scheme" version. > > > > Our configure.ac requires 1.7.1 - so if LZ4_versionString() is not in > > there yet, we might want to bump to 1.7.3 then. > > according to the NEWS file in lz4 there is no such thing as release 1.7.1 > or 1.7.2, it goes from r131 -> v1.7.3. I therefore suggest to set the > minimum version to 1.7.3 as I'm also unable to locate any official 1.7.1 > or 1.7.2 release.
Sounds like a reasonable plan.
> BTW, for 2.4.4 I've changed to patch to the one attached.
>
> Regards,
> Simon
> --- openvpn-2.4.4/src/openvpn/options.c.orig 2017-09-26 11:27:37.000000000
> +0200
> +++ openvpn-2.4.4/src/openvpn/options.c 2017-09-28 06:21:57.977919621
> +0200
> @@ -61,6 +61,10 @@
>
> #include "memdbg.h"
>
> +#if defined(ENABLE_LZ4)
> +#include "lz4.h"
> +#endif
> +
This will fail if we use the bundled LZ4, which has "compat-lz4.h" -
so maybe we really should go back to including "comp-lz4.h" here, and
move the lz4.h/compat-lz4.h including to that one.
("bundled LZ4" is what we can have right now, so we need to take that into
account. If we want to drop it, that's an independent discussion)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
