Hi, On Thu, Aug 16, 2018 at 07:17:09PM +0800, Antonio Quartulli wrote: > I totally agree with you that more ifdefs are just ugly and make the > code worse. However this "new" ifdef is just part of some logic that is > already there (a few lines above).
It is a new #ifdef, two more lines of code, breaking the flow of
reading. So I tend to agree with Mathias that this might not be the
best approach here.
> This said, in the past months we have tried moving towards a
> 0-warnings-tolerance, so that we could catch as many bugs as possible
> hidden by "just annoying warnings".
> For this reason using "-Wno-unused-label" is not an option (especially
> in CI/automated build tests where this was spotted).
I see "unused label" as a minor nuisance (unlike other warnings there
is nothing like "it could be an integer overflow" or "watch out for
the signs of your variables" here), so -Wno-unused-label would work
for me...
Warnings are generally good, but adding extra lines just to silence
the compiler in a specific combination of flags for a warning that is
otherwise harmless is not always a good way forward.
> Imho we should just get this patch through and then try to get rid of
> the whole #ifdef PLUGIN_DEF_AUTH logic at once.
If the idea is to get rid of PLUGIN_DEF_AUTH, then let's do so, not
add extra #ifdef :-)
Anyway. Trying to understand the logic here - PLUGIN_DEF_AUTH is always
defined if ENABLE_DEF_AUTH is set, which seems to be the default setting.
So, questions
- is there actually some benefit in --disable-def-auth? code size,
performance, platform compatibility?
- why do we have it in the first place?
- can we get rid of it?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
