Hi, On 16/08/18 19:37, Gert Doering wrote: >> Imho we should just get this patch through and then try to get rid of >> the whole #ifdef PLUGIN_DEF_AUTH logic at once. > > If the idea is to get rid of PLUGIN_DEF_AUTH, then let's do so, not > add extra #ifdef :-)
Good! Let's focus on that then :) > > > Anyway. Trying to understand the logic here - PLUGIN_DEF_AUTH is always > defined if ENABLE_DEF_AUTH is set, which seems to be the default setting. > > So, questions > > - is there actually some benefit in --disable-def-auth? code size, > performance, platform compatibility? > > - why do we have it in the first place? > to me this feels like the classic pattern of "let's introduce this new feature, but let's add a compile time option in case people have troubles with it or don't want it for some reason". I have seen this often also in newer code (like ovpn3). > - can we get rid of it? > Does any distro package openvpn with --disable-def-auth selected? If not, I guess we can get rid of it. But maybe David knows something we don't :-) Cheers, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
