Acked-by: Gert Doering <g...@greenie.muc.de>

For the reasons given - it's code that has not been activated anywhere
in the last 5+ years, there is no way to turn it on by configure, and
it's likely not working right on half the platforms.  And less #ifdef!

I had to whack the patch to make it apply - no changes to the actual
code, but the context was full of ENABLE_MANAGEMENT where our tree has
ENABLE_CLIENT_CR.  I seem to remember that there was a patch to get rid
of the letter (because it is auto-defined #if ENABLE_MANAGEMENT) but we
seem to have lost track of it... only your tree remembers.

Your patch has been applied to the master branch.

commit 00d78cd57fa52aa5a65df1707922791e72313663
Author: Arne Schwabe
Date:   Mon Oct 8 20:16:16 2018 +0200

     Remove AUTO_USERID feature

     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20181008181618.8976-2-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17664.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to