Am 08.10.18 um 21:37 schrieb Gert Doering:
> Hi,
>
> On Mon, Oct 08, 2018 at 08:16:16PM +0200, Arne Schwabe wrote:
>> There is no user facing way to enable this feature and way that feature
>> works (username build from MAC of primary net device) is questionable.
>>
>> It also does not compile anymore.
>
> Feature-ACK, but the patch itself puzzles me.
>
>> @@ -455,51 +455,6 @@ get_auth_challenge(const char *auth_challenge, struct
>> gc_arena *gc)
>>
>> #endif /* ifdef ENABLE_MANAGEMENT */
>>
>> -#if AUTO_USERID
> [..]
>> diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c
>> index 0a947c6e..5a136d69 100644
>> --- a/src/openvpn/ssl.c
>> +++ b/src/openvpn/ssl.c
>> @@ -410,9 +410,6 @@ auth_user_pass_setup(const char *auth_file, const struct
>> static_challenge_info *
>> auth_user_pass_enabled = true;
>> if (!auth_user_pass.defined && !auth_token.defined)
>> {
>> -#if AUTO_USERID
>> - get_user_pass_auto_userid(&auth_user_pass, auth_file);
>> -#else
>> #ifdef ENABLE_MANAGEMENT
>
> These hunks have "ENABLE_MANAGEMENT" in the context, while all my branches
> (2.3, 2.4, master) have "ENABLE_CLIENT_CR" here.
>
> This is not really needed to remove the (questionable) feature - and I can
> just adjust the patch on the fly - but I wonder where these are coming
> from in your tree, and whether I missed (or messed up) something...
>
You are missing patch 1/4:
[PATCH 1/4] Remove MANAGMENT_EXTERNAL_KEY, MANAGMENT_IN_EXTRA,
ENABLE_CLIENT_CR
Is being held until the list moderator can review it for approval.
The reason it is being held:
Message body is too big: 309191 bytes with a limit of 256 KB
But since it now does not apply anymore since 2/4 got in first, I will
resend that mail and canceld the message request.
Arne
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
