Hi, This was catched by Visual Studio. Moreover, with SDL enabled ( https://docs.microsoft.com/fi-fi/cpp/build/reference/sdl-enable-additional-security-checks?view=vs-2017 ) this warning is treated as an error.
It is probably a good idea to trigger Visual Studio build on every commit to master (and enable SDL), have to think what would be the best way to do it. Currently we build with VS when making PRs to openvpn-build, which we don't do that often. I'm just not sure whether we should add casts, or stop using the 'hack' > of supplying a negative value to frame_add_to_extra_frame. Maybe we > should add a frame_remove_from_extra_frame function instead. What do you > think? > Agreed, semantically it is more clear when _add_ method adds and _remove_ method removes. I'll add _remove_ method and change type of "increment" parameter to unsigned in both methods so that next time when we'll try to use _add_ with negative value, we'll get a warning. -- -Lev
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
