Hi, On Tue, Jun 25, 2019 at 10:34:01PM +0300, Lev Stipakov wrote: > ack_message_t ack; > struct gc_arena gc = gc_new(); > > - if (!send_msg_iservice(pipe, rt, size, &ack, "ROUTE")) > + if (!send_msg_iservice(pipe, rt, size, &ack, sizeof(ack), "ROUTE"))
I do not like this. Please find another way to send the request message
"with length" than to add an extra parameter to every single caller of
send_msg_iservice().
Possibly introduce a wrapper for the "standard" case which calls a new
function send_msg_iservice_ex() that takes a length field for the return
data type. And the open wintun / return handle would then use _ex().
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
