Hi,
On Sat, Jun 29, 2019 at 10:50 AM Lev Stipakov <lstipa...@gmail.com> wrote:
>
> That --allow-nonadmin functionality was included into commit 3c7f2f553 from
> yeah 2005. Here is code from tap-win32/tapdrv.c from the same commit:
>
> +#if ENABLE_NONADMIN
> + /* Read AllowNonAdmin setting from registry */
> + {
> + NDIS_STRING key = NDIS_STRING_CONST("AllowNonAdmin");
> + NdisReadConfiguration (&status, &parm, configHandle,
> + &key, NdisParameterInteger);
> + if (status == NDIS_STATUS_SUCCESS)
> + {
> + if (parm->ParameterType == NdisParameterInteger)
> + {
> + if (parm->ParameterData.IntegerData)
> + {
> + enable_non_admin = TRUE;
> + }
> + }
> + }
> + }
> +#endif
>
> As you see, the current version posted by Selva is missing
>
> if (parm->ParameterData.IntegerData)
>
> part.
>
> So it seems for me that this feature has been degraded somewhere between 2005
> and 2019.
If the idea was to remove the feature, the whole code between those
#if-#endif could have been removed. The way it stands looks like a bug.
Anyway, our installer always sets the AllowNonAdmin key as true, so we will
not break any setups by "fixing" this.
Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
