Acked-by: Gert Doering <[email protected]>
Stared at the code, ran client side tests, full set of server side tests,
and compiled (+client tested) on FreeBSD 7.4 to give the "anonymous union
explosion" bits a good checking :-) (it does not explode anymore, thanks
for fixing that).
Similar to 2/9, this patch does not actually change behaviour yet - it
adds the 2-byte vid to the hashed ethernet address for per-client learning,
but as all callers set it to "0", there is no "vlan separation" effect
yet (I know it's coming in a future patch, just pointing out why this
patch does not change visible behaviour yet).
It shows up in the "MULTI: Learn" lines already, though
Nov 6 22:04:51 gentoo tap-udp-p2mp[11510]:
freebsd-11-amd64/2001:608:0:814::f000:16 MULTI: Learn: 00:bd:b5:63:b5:04@0 ->
freebsd-11-amd64/2001:608:0:814::f000:16
.. the "@0" bit after the MAC address is the PVID.
As a side note: it seems that whoever did the IPv6 payload patches was
a bit sloppy (it was me, so I am allowed to say that). MAC learning is
only done on IPv4 and ARP packets, but not on IPv6 packets - so I expect
"ipv6 only mode on tap" to be a bit wacky... this needs re-testing
before we can declare "ipv6-only works reliably".
Your patch has been applied to the master branch.
commit a2b7230712dbc8cfab85d5bd59605f58fc5fe5f8
Author: Antonio Quartulli
Date: Wed Oct 9 16:34:16 2019 +0200
maddr: export VLAN ID from client context to maddr object
Signed-off-by: Fabian Knittel <[email protected]>
Signed-off-by: Antonio Quartulli <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg18917.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
