Acked-by: Gert Doering <g...@greenie.muc.de>

This is one of the easy ones, and very "obviously correct".  Client side
tested on Linux and FreeBSD with t_client / TAP tests (which do not really
excercise this code, unfortunately, but my test server is still down).

While I do prefer memcpy()'s using "sizeof(dest)" to "OPENVPN_ETH_ALEN", 
mroute.eth_addr is "uint8_t[OPENVPN_ETH_ALEN]" so this is safe enough.

Your patch has been applied to the master branch.

commit 5e27e47d631f61ee3f9234dd076389232495e714
Author: Antonio Quartulli
Date:   Wed Oct 9 16:34:14 2019 +0200

     maddr: create helper function to populate maddr object from eth_addr

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20191009143422.9419-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18921.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to