>> > > Other than my little nitpicks above, the patch looks good. > However, I have a question. > > Since you are refactoring this code and this is going to master/2.5, why > not reimplementing the get_num_elements() function using strtok() ? >
strsep/strok have the disadvantage of modifying the passed string, requring copying the string. strok in addition breaks on recursive calls. Also the for loop is very to understand and from playing with godbolt (https://godbolt.org/z/RVtjVL) it looks that the compilers will optimise/vectorise this function so using C string function will probably be even slower. So the simple and easy to understand function is the best choice here IMHO. Will send a V2 with the formatting/description fixed. Arne
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
