Hi, On 17/04/2020 09:47, Arne Schwabe wrote: > Am 16.04.20 um 00:31 schrieb Antonio Quartulli: >> is it really important to clone "groups" ? why just not chopping it ? >> It shouldn't be re-used any more I think. > > Maybe but modifying a parameter as side effect does not feel right. I > rather have a clean API here instead of this unintended side stuff that > can lead to kind of interesting bugs.
yeah, makes sense. > >> If we really really need to alloc this memory, can't we get a gc from >> outside? maybe from the option parser? We normally avoid explicit >> alloc/free in the code. > > The problem with a gc from the outside is that we don't really want to > tie up the memory in options->gc as that would just be extra memory that > is allocated the whole session I will update the patch to use a local gc. > yeah, that would fit our style I think. Thanks! -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
