HI, On Sat, May 30, 2020 at 02:05:57AM +0200, Antonio Quartulli wrote: > From: Antonio Quartulli <anto...@openvpn.net> > > Without altering the pool logic, this patch enables using > a persistent IP pool also when the server is configured > with IPv6 only. > > Trac: #208 > Signed-off-by: Antonio Quartulli <anto...@openvpn.net>
NAK, as discussed on IRC, because this breaks (surprisingly) persistent
pools for IPv4-only pools.
(An ipp.txt entry of just "CN,IPv4" will not pass the 3rd buf_parse()
call, and thus be ignored as "malformed" - so pool assignments are lost
at every server restart)
The rest of the code looks good, and it seems to work correctly on the
t_server setup.
While at it, one cosmetic change:
> @@ -459,23 +525,26 @@ ifconfig_pool_list(const struct ifconfig_pool *pool,
> struct status_output *out)
> for (i = 0; i < pool_size; ++i)
> {
> const struct ifconfig_pool_entry *e = &pool->list[i];
> + struct in6_addr ip6;
> + in_addr_t ip;
I find these two declarations a bit awkward - they are "in a block",
but it's not "the block where they are needed"... the old code had
on-the-fly declarations
> - const in_addr_t ip = ifconfig_pool_handle_to_ip_base(pool,
> i);
...
> - struct in6_addr ip6 =
> ifconfig_pool_handle_to_ipv6_base(pool, i);
which, I assume, you removed due to line length considerations?
This is not a reason for NAKing, though. Just something I found surprising.
thanks :)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
