Acked-by: Gert Doering <g...@greenie.muc.de>

Much nicer code than in v4 :-)

Stared-at-code, and ran the t_client and t_server tests with ipv4-only,
ipv4+ipv6 and ipv6-only pools (ipv4-only is something I never wanted to
do again... :-) ).

Tested pool mishandling ("corrupt" and "out-of-bounds" v4+v6 addresses,
mismatching pool indexes, etc.) - and that all behaves like planned. \o/

Something for the cleanup patch: pool.c seems to have grown an include
for "options.h", but I can not see a reason why this is needed (it
compiles fine without)...?

Your patch has been applied to the master branch.

commit 6a8cd033b1812a26b9b35c17eef33240d7ac2719
Author: Antonio Quartulli
Date:   Sat Jun 6 23:16:24 2020 +0200

     pool: add support for ifconfig-pool-persist with IPv6 only

     Signed-off-by: Antonio Quartulli <anto...@openvpn.net>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20200606211624.10877-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19990.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to