Hi, On Fri, Jul 10, 2020 at 06:48:26PM +0200, Jan Just Keijser wrote: > > It's just a comment, but if that is wrong, it's not helpful in trying to > > understand the code. > > > just submitted patch v4 but forgot to fix that: richard is right 29 > decimal is 0x1D - or just 29, I guess - not 0x13 > > Want a v5 for that :P ?
If the rest is working nicely, I usually fix comment or commit message
errors (if the proposer agrees) on the fly.
So, will test v4 tomorrow, and then report back :-)
While I couldn't sleep a few nights ago, I came up with a more elegant
approach than strtok()/strchr()/strsep() though... just walk the string,
remember where to put the lenght byte, and every time you hit a "." or
"\0", put (p-lenght_p)-1 into *length_p and remember the current position
as new "length_p"... less code, no remainder to deal with, and
single-pass... :-) - so if v4 is not working yet, that might be another
thing for v5.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
