Your patch has been applied to the master branch. White space has been whacked as instructed :-)
Tested (yesterday) already on the server test rig, all good. The code changes look good (though I find the patch granularity "too fine", with all the extra calls to cc_check_return() added just to have them removed again further down the series). I object to the use of the term "call-back" functions, because they aren't... it's just a series of helpers that are called via a function pointer array later on, but there is no "back" involved anywhere ("pass a function pointer down to a library that does a call-back into your code to do things"). commit 4f29b73b168904a764151f1acef0ea73c0fcece1 Author: Fabian Knittel Date: Sat Jul 11 11:36:46 2020 +0200 client-connect: Refactor to use return values instead of modifying a passed-in flag Signed-off-by: Fabian Knittel <fabian.knit...@lettink.de> Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Antonio Quartulli <a...@unstable.cc> Message-Id: <20200711093655.23686-5-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20286.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel