Hi Tony, Thanks a lot for your interest in ovpn-dco!
It's amazing to see other people putting effort in using and testing our
new kernel module :-)
See my replies below:
On 18/11/2020 03:31, ???? wrote:
> /usr/include/libnl3/netlink/handlers.h:51:15: warning: ??struct nlmsgerr??
> declared inside parameter list will not be visible outside of this
> definition or declaration?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2?0?2
> ?0?2 ?0?2 ?0?2 ?0?2 struct nlmsgerr *nlerr, void *arg);
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2^~~~~~~~
> /usr/include/libnl3/netlink/handlers.h:50:43: warning: ??struct
> sockaddr_nl?? declared inside parameter list will not be visible outside
> of this definition or declaration
> ?0?2typedef int (*nl_recvmsg_err_cb_t)(struct sockaddr_nl *nla,
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2^~~~~~~~~~~
> /usr/include/libnl3/netlink/handlers.h:135:18: warning: ??struct
> sockaddr_nl?? declared inside parameter list will not be visible outside
> of this definition or declaration
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2struct sockaddr_nl *,
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ^~~~~~~~~~~
> ovpn-cli.c: In function ??ovpn_nl_msg_send??:
> ovpn-cli.c:232:38: warning: passing argument 3 of ??nl_cb_err?? from
> incompatible pointer type [-Wincompatible-pointer-types]
> ?0?2 nl_cb_err(ctx->nl_cb, NL_CB_CUSTOM, ovpn_nl_cb_error, &status);
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2
> ?0?2 ?0?2 ?0?2 ?0?2 ^~~~~~~~~~~~~~~~
> In file included from /usr/include/libnl3/netlink/socket.h:16:0,
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2from ovpn-cli.c:17:
> /usr/include/libnl3/netlink/handlers.h:127:13: note: expected
> ??nl_recvmsg_err_cb_t {aka int (*)(struct sockaddr_nl *, struct nlmsgerr
> *, void *)}?? but argument is of type ??int (*)(struct sockaddr_nl *,
> struct nlmsgerr *, void *)??
> ?0?2extern int?0?2 nl_cb_err(struct nl_cb *, enum nl_cb_kind,
> nl_recvmsg_err_cb_t,
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2^~~~~~~~~
We haven't seen this issue so far, probably because we are using a more
recent libnl version (we test with libnl3.4 and libnl3.5).
I added a potential fix in latest master.
> ovpn-cli.c: In function ??ovpn_read_cipher??:
> ovpn-cli.c:355:17: error: ??OVPN_CIPHER_ALG_CHACHA20POLY1305?? undeclared
> (first use in this function); did you mean
> ??OVPN_CIPHER_ALG_CHACHA20_POLY1305???
> ?0?2 ?0?2ctx->cipher = OVPN_CIPHER_ALG_CHACHA20POLY1305;
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2 ?0?2OVPN_CIPHER_ALG_CHACHA20_POLY1305
Ouch, this is my fault. It is fixed in the latest master now.
Can you please give latest master another try and let us know?
Thanks!
--
Antonio Quartulli
OpenPGP_0x48F0CCB68F59D14C.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
