[Openvpn-devel] ?????? [ovpn-dco] It seems not to compile ovpn-cli successfully

[Tony]

Hi Antonio,


Thanks. Confirmed this issue has been fixed. Will test performance. If more 
issues are encountered, will report.


Tony




------------------ ???????? ------------------
??????:                                                                         
                                               "Antonio Quartulli"              
                                                                      
<a...@unstable.cc&gt;;
????????:&nbsp;2020??11??18??(??????) ????3:36
??????:&nbsp;"Tony"<383181...@qq.com&gt;;"Openvpn-devel"<openvpn-devel@lists.sourceforge.net&gt;;"antonio"<anto...@openvpn.net&gt;;"lev"<l...@openvpn.net&gt;;

????:&nbsp;Re: [Openvpn-devel] [ovpn-dco] It seems not to compile ovpn-cli 
successfully



Hi Tony,

Thanks a lot for your interest in ovpn-dco!

It's amazing to see other people putting effort in using and testing our
new kernel module :-)

See my replies below:

On 18/11/2020 03:31, ???? wrote:
&gt; /usr/include/libnl3/netlink/handlers.h:51:15: warning: ??struct nlmsgerr??
&gt; declared inside parameter list will not be visible outside of this
&gt; definition or declaration&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp;
&gt; &nbsp; &nbsp; &nbsp; &nbsp; struct nlmsgerr *nlerr, void *arg);
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;^~~~~~~~
&gt; /usr/include/libnl3/netlink/handlers.h:50:43: warning: ??struct
&gt; sockaddr_nl?? declared inside parameter list will not be visible outside
&gt; of this definition or declaration
&gt; &nbsp;typedef int (*nl_recvmsg_err_cb_t)(struct sockaddr_nl *nla,
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp;^~~~~~~~~~~
&gt; /usr/include/libnl3/netlink/handlers.h:135:18: warning: ??struct
&gt; sockaddr_nl?? declared inside parameter list will not be visible outside
&gt; of this definition or declaration
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;struct sockaddr_nl *,
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ^~~~~~~~~~~
&gt; ovpn-cli.c: In function ??ovpn_nl_msg_send??:
&gt; ovpn-cli.c:232:38: warning: passing argument 3 of ??nl_cb_err?? from
&gt; incompatible pointer type [-Wincompatible-pointer-types]
&gt; &nbsp; nl_cb_err(ctx-&gt;nl_cb, NL_CB_CUSTOM, ovpn_nl_cb_error, 
&amp;status);
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ^~~~~~~~~~~~~~~~
&gt; In file included from /usr/include/libnl3/netlink/socket.h:16:0,
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;from 
ovpn-cli.c:17:
&gt; /usr/include/libnl3/netlink/handlers.h:127:13: note: expected
&gt; ??nl_recvmsg_err_cb_t {aka int (*)(struct sockaddr_nl *, struct nlmsgerr
&gt; *, void *)}?? but argument is of type ??int (*)(struct sockaddr_nl *,
&gt; struct nlmsgerr *, void *)??
&gt; &nbsp;extern int&nbsp; nl_cb_err(struct nl_cb *, enum nl_cb_kind, 
nl_recvmsg_err_cb_t,
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;^~~~~~~~~

We haven't seen this issue so far, probably because we are using a more
recent libnl version (we test with libnl3.4 and libnl3.5).

I added a potential fix in latest master.


&gt; ovpn-cli.c: In function ??ovpn_read_cipher??:
&gt; ovpn-cli.c:355:17: error: ??OVPN_CIPHER_ALG_CHACHA20POLY1305?? undeclared
&gt; (first use in this function); did you mean
&gt; ??OVPN_CIPHER_ALG_CHACHA20_POLY1305???
&gt; &nbsp; &nbsp;ctx-&gt;cipher = OVPN_CIPHER_ALG_CHACHA20POLY1305;
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp;^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp;OVPN_CIPHER_ALG_CHACHA20_POLY1305

Ouch, this is my fault. It is fixed in the latest master now.


Can you please give latest master another try and let us know?


Thanks!


-- 
Antonio Quartulli

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel