Hi, On Sun, Dec 05, 2021 at 03:57:55AM +0100, Arne Schwabe wrote: > > The refactoring makes it very hard to see what the actual change is. Maybe > > it would be better to split this in two commits? > > > > The only actual change in behavior is the "|| o->pull", right? > > Yes. But should I really split up this 5 line patch into two patches? > That feels a bit excessive.
I'm fine with a single patch here.
I need to think a bit more into "what conditions is this checking, exactly,
and why?" - but with refactoring, I'd have to do that thinking twice :-)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
