> Gert Doering <g...@greenie.muc.de> hat am 05.12.2021 11:19 geschrieben:
>
>
> Hi,
>
> On Sun, Dec 05, 2021 at 03:57:55AM +0100, Arne Schwabe wrote:
> > > The refactoring makes it very hard to see what the actual change is.
> > > Maybe it would be better to split this in two commits?
> > >
> > > The only actual change in behavior is the "|| o->pull", right?
> >
> > Yes. But should I really split up this 5 line patch into two patches?
> > That feels a bit excessive.
>
> I'm fine with a single patch here.
>
> I need to think a bit more into "what conditions is this checking, exactly,
> and why?" - but with refactoring, I'd have to do that thinking twice :-)
I disagree. If you had one patch that does refactoring but does not intend any
functional change,
and one patch that just adds "|| o->pull", the general understanding of each
patch would require
much less time and thinking. Mostly it would be much easier to match the change
with the intent
communicated by the commit message. Which for me was the hardest part, here.
Regards,
Frank
--
Frank Lichtenheld
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
