Acked-by: Gert Doering <g...@greenie.muc.de>
Thanks for the v3 changes.
I tested v2 very thoroughly on "non sitnl" builds (FreeBSD, Linux with
--enable-iproute2) to make sure this really only affects sitnl - and
that has not changed with v3. What has changed is "-errno", typo fix
in the commit message, and the extra test for "what happens if the
interface does not exist?" - these have been tested in a sitnl build,
and pass.
OpenVPN itself does not yet use that new function, only the unit test.
As agree on IRC, we do not touch the bash-nature of t_net.sh today -
we might want to move to "more POSIX" one day, but today Linux systems
are assumed to have bash, and this is really linux (+sitnl) only.
Your patch has been applied to the master branch.
commit 26b6b6f0673fa1f3806c447a18bb0f705b231b35
Author: Antonio Quartulli
Date: Wed Jul 13 14:43:32 2022 +0200
networking: add net_iface_type API
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20220713124332.16147-...@unstable.cc>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24688.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
