On Tue, Aug 02, 2022 at 05:16:04PM +0200, Antonio Quartulli wrote:
> Data channel keys are periodically regenarated and installed in
> ovpn-dco.
> However, there is a certain moment when keys are rotated in order
> to elect the new primary one.
> 
> Check the key status in userspace so that kernelspace can be informed as
> well when rotations happen.
> 
> Signed-off-by: Antonio Quartulli <a...@unstable.cc>
> ---
> 
> Changes from v2:
> * reworked dco_update_keys():
> ** removed existing ASSERTs on keys and converted into something more
>    logic and related to the flow
> ** fixed comment about userspace (use "we" for more clarity)
> ** add error code handling. The idea is to abort operations as soon as a
>    failure is detected, so that the next iteration can make another
>    attempt.

Looks to me like this addresses all my comments.

Regards,
-- 
  Frank Lichtenheld


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to