Acked-by: Gert Doering <g...@greenie.muc.de>

The review of that was a combined effort, mostly Frank on mail and
Antonio and I on IRC - but the v3 is now easier to understand, and
"should work nicely".

I have slightly extended the comment before "swapping primary and
secondary keys" to make a bit clearer how we end there (we discussed
that comment on IRC).

This said, I have only tested the "no DCO in kernel" cases, as the
rest is still missing functinality - and for "no DCO", this becomes
fairly much "no change", as the only new code otherwise is guarded
with "if (!dco_enabled(&c->options))".

Your patch has been applied to the master branch.

commit cd4ba9279d9c4cf13cdc3d8c49143c57eb0fe448
Author: Antonio Quartulli
Date:   Tue Aug 2 17:16:04 2022 +0200

     dco: periodically check and possibly rotate/delete keys

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20220802151604.2801-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24785.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to